Fix: lazy evaluation for logical expressions (#27) (#28)

* fix logical expression short-circuit evaluation (#27)

* test logical short-circuit cases (#27)

src/operators.ts

@@ -37,8 +37,15 @@ const binaryBooleanArithmetic = (
 const bool = (value: LuaType): boolean => coerceToBoolean(value)
 
 // logical
-const and = (l: LuaType, r: LuaType): LuaType => coerceToBoolean(l) ? r : l
+const and = (l: () => LuaType, r: () => LuaType): LuaType => {
-const or = (l: LuaType, r: LuaType): LuaType => coerceToBoolean(l) ? l : r
+	const lv = l()
+	return coerceToBoolean(lv) ? r() : lv
+}
+
+const or = (l: () => LuaType, r: () => LuaType): LuaType => {
+	const lv = l()
+	return coerceToBoolean(lv) ? lv : r()
+}
 
 // unary
 const not = (value: LuaType): boolean => !bool(value)

src/parser.ts

@@ -303,10 +303,10 @@ const generate = (node: luaparse.Node): string | MemExpr => {
             const operator = node.operator
 
             if (operator === 'and') {
-                return `__lua.and(${left},${right})`
+                return `__lua.and(() => ${left}, () => ${right})`
             }
             if (operator === 'or') {
-                return `__lua.or(${left},${right})`
+                return `__lua.or(() => ${left}, () => ${right})`
             }
             throw new Error(`Unhandled logical operator: ${node.operator}`)
         }

tests/lua-5.3/logical_operations.lua

@@ -0,0 +1,6 @@
+local x = nil
+local x_ = (x and x.k or "fallback")
+assert(x_ == "fallback")
+local y = "ok"
+local y_ = (y or error("should not raise"))
+assert(y == y_)

tests/test.js

@@ -24,6 +24,7 @@ let exitCode = 0
     })
     luaEnv.parseFile('goto.lua').exec()
     luaEnv.parseFile('bwcoercion.lua').exec()
+    luaEnv.parseFile('logical_operations.lua').exec()
 }
 
 {